Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attachable to LandingPage model #9552

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

KludgeKML
Copy link
Contributor

@KludgeKML KludgeKML commented Oct 23, 2024

https://trello.com/c/bUVC9hYD/123-csv-data-as-attachments-in-whitehall

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@KludgeKML KludgeKML changed the title Add images/attachable to model Add attachable to model Oct 28, 2024
@KludgeKML KludgeKML changed the title Add attachable to model Add attachable to LandingPage model Oct 28, 2024
@KludgeKML KludgeKML marked this pull request as ready for review October 28, 2024 17:05
Copy link
Contributor

@richardTowers richardTowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and appears to work when I run it locally (I get an "Attachments for landing page" interface, I haven't actually tried attaching anything but I assume it works.

@KludgeKML KludgeKML merged commit c7478f8 into main Oct 29, 2024
19 checks passed
@KludgeKML KludgeKML deleted the landing-page-attachments branch October 29, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants